Closed eclare108213 closed 9 months ago
This looks fine. Would you like me to run a regression test suite?
I have a base_suite regression test running now - looks good so far.
base_suite came back fully BFB, although results could change in longer runs with BL99. Ready for review/merge.
[x] Short (1 sentence) summary of your PR: Bug fix for BL99 and minor cleanup:
correct ks units in dEdd code
clean up comment statements
uncomment enthalpy calculation when temperature is adjusted, for BL99 thermo (bug fix)
[x] Developer(s): @eclare108213
[x] Suggest PR reviewers from list in the column to the right.
[x] Please copy the PR test results link or provide a summary of testing completed below. base_suite is BFB:
It's likely that results with BL99 thermo will not be BFB if/when the bug fix condition is hit.
How much do the PR code changes differ from the unmodified code?
Does this PR create or have dependencies on CICE or any other models?
Does this PR add any new test cases?
Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
[x] Please provide any additional information or relevant details below: Closes https://github.com/CICE-Consortium/Icepack/issues/450