CICE-Consortium / Icepack

Development repository for sea-ice column physics
Other
25 stars 131 forks source link

Update pull request template, Update conda_macos debug flag #484

Closed apcraig closed 6 months ago

apcraig commented 6 months ago

PR checklist

Update pull request template to ask for additional information about the PR. This information can and will be used during the squash merge process to produce more useful commit logs.

Update Macros.conda_macos to remove ffpe-trap=invalid from debug flags. This flag causes nf90_create to fail with the latest version of the conda environment. This happens when debug flags are on and a test with netcdf is turned on. I believe this is a compiler error.

apcraig commented 6 months ago

Testing is working again on ghactions. I also duplicated the problem on my mac desktop with the latest conda env and verified the update to the debug flag fixed the error. I think this is a compiler problem. nf90_create seg faults when netcdf+debug is turned on for reasons I was not able to understand. This just started recently and with an update to the conda env, probably a newer version of the gnu compiler.

Feel free to have another look at the PR. Unless I hear any feedback, I'll merge tonight or tomorrow.

dabail10 commented 6 months ago

This is weird. I just build the environment today. So, maybe I am not getting the newest somehow?

apcraig commented 6 months ago

@dabail10, I have given up trying to understand the many subtle issues with conda and github actions. My goal is just to keep them functioning as best as I can.