Open zhaobin74 opened 2 months ago
HI @zhaobin74. Thanks for putting these together. I've had a quick look and they look pretty reasonable. But I will go thru the modification in Icepack and CICE carefully and provide some feedback. We are in the process of updating several interfaces as part of a bgc upgrade, so depending on progress on that task, some revisions may be needed here for that too. But I don't think that will be a big problem, and we can work together to bring your changes into the code cleanly. More soon.
HI @zhaobin74. Thanks for putting these together. I've had a quick look and they look pretty reasonable. But I will go thru the modification in Icepack and CICE carefully and provide some feedback. We are in the process of updating several interfaces as part of a bgc upgrade, so depending on progress on that task, some revisions may be needed here for that too. But I don't think that will be a big problem, and we can work together to bring your changes into the code cleanly. More soon.
Thanks, @apcraig. All sounds good. Look forward to working with you and others on this PR.
Hi @zhaobin74, haven't forgotten about this. I'm trying to get an update to bgc into the code before we test/merge your modifications. This PR is high priority, sorry for the delays.
Hi @zhaobin74, haven't forgotten about this. I'm trying to get an update to bgc into the code before we test/merge your modifications. This PR is high priority, sorry for the delays.
Hi @apcraig, just back from leave. No problem, we can deal with it later.
PR checklist
GEOSCOUPLED
macro to isolate the relevant code specific to GEOSHi Consortium, I am putting this PR in draft mode for now to get feedbacks. I am happy to improve it with your help and suggestions.