CICE-Consortium / Icepack

Development repository for sea-ice column physics
Other
25 stars 133 forks source link

Alternative congelation formulation following Plante et al. 2024 #494

Closed eclare108213 closed 3 months ago

eclare108213 commented 3 months ago

Draft for Plante et al. to confirm that these changes are all that are needed, separate from their flooding/snow-ice and forcing modifications. I still need to add tests to the test suite and update the Icepack documentation, then implement and test in CICE. Suggestions for better congel_freeze option labels are welcome.

I realigned some columns while working on this. Ignore white space when looking at diffs!

Namelist flag congel_freeze chooses which formulation to use. The original is ‘two-step’, since only the mushy boundary moves in the first step and the phase change happens in the next step. Plante et al. (‘one-step’) moves the boundary and performs the phase change in a single time step.

Closes #481

apcraig commented 3 months ago

Will need some changes in Icepack documentation and maybe add a test case. Also need to update the icepack interface documentation (run ./icepack.setup --docintfc). CICE will also eventually need a new namelist added.

apcraig commented 3 months ago

See also https://github.com/CICE-Consortium/CICE/pull/965

This PR and the CICE PR are ready to merge assuming we are happy leaving the old 'two-step' as the default. Please confirm that's how we want to proceed. We can always change the default later.

dabail10 commented 2 months ago

I did do a fully-coupled test here with the one-step option and the solutions are quite different. Climate changing? Maybe not, but I think this is the correct way to go. We will definitely be using this in CESM3.