search

CID15 / aem-groovy-console

The AEM Groovy Console provides an interface for running Groovy scripts in the AEM container. Scripts can be created to manipulate content in the JCR, call OSGi services, or execute arbitrary code using the CQ, Sling, or JCR APIs.
Other
24 stars 15 forks source link

Package Overlaps #11

Open alexanderigeorgiev opened 2 years ago

alexanderigeorgiev commented 2 years ago

Hello, We are using groovy console version 17.0.0 on AEM as a Cloud Service. The pipeline execution includes some code scanning and one of its findings is this one:

File: org.cid15.aem.groovy.console:aem-groovy-console-ui.config:17.0.0 Issue: affected path /apps/groovyconsole/osgiconfig overlaps [aem-groovy-console:aem-groovy-console-ui.apps:17.0.0] Adobe rule Package Overlaps is explained here https://experienceleague.adobe.com/docs/experience-manager-cloud-manager/using/how-to-use/custom-code-quality-rules.html?lang=en#oakpal-no-overlap (https://www.adobe.com/go/aem_cmcq_packageoverlaps_en)

In summary two packages aem-groovy-console-ui.config and aem-groovy-console-ui.apps are both writing to /apps/groovyconsole/osgiconfig. That should not happen.

Is is possible that this is fixed in some of the upcoming releases?

Narendiran100 commented 6 months ago

Any update on this

kwin commented 6 months ago

You should consider switching to the maintained fork at https://github.com/orbinson/aem-groovy-console/tree/main which has this issue (and several others) fixed.

alexanderigeorgiev commented 6 months ago

Switching to version 19.0.4 of be.orbinson.aem is fixing the package overlaps issue

On Wed, 10 Jan 2024 at 10:39, Narendiran100 @.***> wrote:

Any update on this

— Reply to this email directly, view it on GitHub https://github.com/CID15/aem-groovy-console/issues/11#issuecomment-1884406922, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEF4F5NYD7MINR3U4OXXUBDYNZHTPAVCNFSM5Y2Q3EUKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOBYGQ2DANRZGIZA . You are receiving this because you authored the thread.Message ID: @.***>