search

CIDARLAB / clotho3

Clotho is a framework for engineering synthetic biological systems and managing the data used to create them. You can author data schemas, run functions and algorithms, and tie Clotho into existing applications.
BSD 3-Clause "New" or "Revised" License
3 stars 0 forks source link

non-API channels (e.g. recent()) close Socket #194

Closed maxbates closed 10 years ago

maxbates commented 10 years ago

Issuing a command on clotho.recent() - not from search bar but directly - crashes the socket.

spaige commented 10 years ago

I'm going to put a pass-through clause for validate and recent, so they don't close the socket. Any other planned channel names that should be accepted?

maxbates commented 10 years ago

Why a pass through? Doesn't validate have something working already? Non-API channels shouldn't close the socket...

On Fri, Apr 11, 2014 at 10:16 AM, Stephanie Paige notifications@github.com wrote:

I'm going to put a pass-through clause for validate and recent, so they don't close the socket. Any other planned channel names that should be accepted?

Reply to this email directly or view it on GitHub: https://github.com/CIDARLAB/clotho3/issues/194#issuecomment-40227332

spaige commented 10 years ago

The passthrough would be faster than testing validate. I assumed urgent meant ASAP.

Why should we tolerate abnormal input? There's a set list of valid channels, clients have no reason to send input on invalid channels.

spaige commented 10 years ago

@jcaucb There was an entry in the Channel enum called requestRecent (commented as: Return the latest-used Sharables from the Mind). I'm renaming that to recent. Let me know if those are not equivalent.

jcaucb commented 10 years ago

the requestRecent method is for the searchbar algorithm. I was not imagining that this would be an exposed method of the API (at least at this time). It certainly could be, though.

On Fri, Apr 11, 2014 at 10:34 AM, Stephanie Paige notifications@github.comwrote:

@jcaucb https://github.com/jcaucb There was an entry in the Channel enum called requestRecent (commented as: Return the latest-used Sharables from the Mind). I'm renaming that to recent. Let me know if those are not equivalent.

Reply to this email directly or view it on GitHubhttps://github.com/CIDARLAB/clotho3/issues/194#issuecomment-40229128 .

J. Christopher Anderson, Ph.D. Assistant Professor Department of Bioengineering http://andersonlab.qb3.berkeley.edu/

Office: 512E Energy Biosciences Building (EBB) Lab: 5th Floor EBB

Mailing Address: J. Christopher Anderson University of California, Berkeley 512E Energy Biosciences Building Berkeley, CA 94720

jcaucb commented 10 years ago

oh....you're saying it's already in the API, or a stub of it exists. Um, I'm ambivalent as to whether that needs to be implemented. The searchbar will not involve the client requesting the recent list from the server.

On Fri, Apr 11, 2014 at 10:46 AM, J. Christopher Anderson < jcanderson2167@gmail.com> wrote:

the requestRecent method is for the searchbar algorithm. I was not imagining that this would be an exposed method of the API (at least at this time). It certainly could be, though.

On Fri, Apr 11, 2014 at 10:34 AM, Stephanie Paige < notifications@github.com> wrote:

@jcaucb https://github.com/jcaucb There was an entry in the Channel enum called requestRecent (commented as: Return the latest-used Sharables from the Mind). I'm renaming that to recent. Let me know if those are not equivalent.

Reply to this email directly or view it on GitHubhttps://github.com/CIDARLAB/clotho3/issues/194#issuecomment-40229128 .

J. Christopher Anderson, Ph.D. Assistant Professor Department of Bioengineering http://andersonlab.qb3.berkeley.edu/

Office: 512E Energy Biosciences Building (EBB) Lab: 5th Floor EBB

Mailing Address: J. Christopher Anderson University of California, Berkeley 512E Energy Biosciences Building Berkeley, CA 94720

J. Christopher Anderson, Ph.D. Assistant Professor Department of Bioengineering http://andersonlab.qb3.berkeley.edu/

Office: 512E Energy Biosciences Building (EBB) Lab: 5th Floor EBB

Mailing Address: J. Christopher Anderson University of California, Berkeley 512E Energy Biosciences Building Berkeley, CA 94720

jcaucb commented 10 years ago

(renaming it to recent would be fine, but it also can be silenced out)

On Fri, Apr 11, 2014 at 10:47 AM, J. Christopher Anderson < jcanderson2167@gmail.com> wrote:

oh....you're saying it's already in the API, or a stub of it exists. Um, I'm ambivalent as to whether that needs to be implemented. The searchbar will not involve the client requesting the recent list from the server.

On Fri, Apr 11, 2014 at 10:46 AM, J. Christopher Anderson < jcanderson2167@gmail.com> wrote:

the requestRecent method is for the searchbar algorithm. I was not imagining that this would be an exposed method of the API (at least at this time). It certainly could be, though.

On Fri, Apr 11, 2014 at 10:34 AM, Stephanie Paige < notifications@github.com> wrote:

@jcaucb https://github.com/jcaucb There was an entry in the Channel enum called requestRecent (commented as: Return the latest-used Sharables from the Mind). I'm renaming that to recent. Let me know if those are not equivalent.

Reply to this email directly or view it on GitHubhttps://github.com/CIDARLAB/clotho3/issues/194#issuecomment-40229128 .

J. Christopher Anderson, Ph.D. Assistant Professor Department of Bioengineering http://andersonlab.qb3.berkeley.edu/

Office: 512E Energy Biosciences Building (EBB) Lab: 5th Floor EBB

Mailing Address: J. Christopher Anderson University of California, Berkeley 512E Energy Biosciences Building Berkeley, CA 94720

J. Christopher Anderson, Ph.D. Assistant Professor Department of Bioengineering http://andersonlab.qb3.berkeley.edu/

Office: 512E Energy Biosciences Building (EBB) Lab: 5th Floor EBB

Mailing Address: J. Christopher Anderson University of California, Berkeley 512E Energy Biosciences Building Berkeley, CA 94720

J. Christopher Anderson, Ph.D. Assistant Professor Department of Bioengineering http://andersonlab.qb3.berkeley.edu/

Office: 512E Energy Biosciences Building (EBB) Lab: 5th Floor EBB

Mailing Address: J. Christopher Anderson University of California, Berkeley 512E Energy Biosciences Building Berkeley, CA 94720

spaige commented 10 years ago

@jcaucb Okay, I'm removing it from the channel enum.

spaige commented 10 years ago

@maxbates What do you expect the recent channel to do?

maxbates commented 10 years ago

recent(n) should fetch the most n recently used sharables from the Mind, or something to that effect initially.

From: Stephanie Paige notifications@github.com Reply: CIDARLAB/clotho3 reply@reply.github.com Date: April 11, 2014 at 11:18:36 AM To: CIDARLAB/clotho3 clotho3@noreply.github.com Cc: Maxwell Bates maxbates@gmail.com Subject:  Re: [clotho3] non-API channels (e.g. recent()) close Socket (#194)

Closed #194 via 5ed0ddb.

— Reply to this email directly or view it on GitHub.

jcaucb commented 10 years ago

Is there any planned usage of recent(n)? On Apr 11, 2014 11:23 AM, "Maxwell Bates" notifications@github.com wrote:

recent(n) should fetch the most n recently used sharables from the Mind, or something to that effect initially.

From: Stephanie Paige notifications@github.com Reply: CIDARLAB/clotho3 reply@reply.github.com Date: April 11, 2014 at 11:18:36 AM To: CIDARLAB/clotho3 clotho3@noreply.github.com Cc: Maxwell Bates maxbates@gmail.com Subject: Re: [clotho3] non-API channels (e.g. recent()) close Socket (#194)

Closed #194 via 5ed0ddb.

Reply to this email directly or view it on GitHub.

Reply to this email directly or view it on GitHubhttps://github.com/CIDARLAB/clotho3/issues/194#issuecomment-40237873 .

maxbates commented 10 years ago

There is no way of browsing the database or what you’ve been working on, this would be an easy first pass to set up

From: J. Christopher Anderson notifications@github.com Reply: CIDARLAB/clotho3 reply@reply.github.com Date: April 11, 2014 at 12:07:21 PM To: CIDARLAB/clotho3 clotho3@noreply.github.com Cc: Maxwell Bates maxbates@gmail.com Subject:  Re: [clotho3] non-API channels (e.g. recent()) close Socket (#194)

Is there any planned usage of recent(n)? On Apr 11, 2014 11:23 AM, "Maxwell Bates" notifications@github.com wrote:

recent(n) should fetch the most n recently used sharables from the Mind, or something to that effect initially.

From: Stephanie Paige notifications@github.com Reply: CIDARLAB/clotho3 reply@reply.github.com Date: April 11, 2014 at 11:18:36 AM To: CIDARLAB/clotho3 clotho3@noreply.github.com Cc: Maxwell Bates maxbates@gmail.com Subject: Re: [clotho3] non-API channels (e.g. recent()) close Socket (#194)

Closed #194 via 5ed0ddb.

Reply to this email directly or view it on GitHub.

Reply to this email directly or view it on GitHubhttps://github.com/CIDARLAB/clotho3/issues/194#issuecomment-40237873 .

— Reply to this email directly or view it on GitHub.