CIDARLAB / clotho3

Clotho is a framework for engineering synthetic biological systems and managing the data used to create them. You can author data schemas, run functions and algorithms, and tie Clotho into existing applications.
BSD 3-Clause "New" or "Revised" License
3 stars 0 forks source link

Distinguish between Schemas with same name #484

Closed billcao closed 9 years ago

billcao commented 9 years ago

Names do not have to be unique in Clotho (only id's are unique), thus many drop down menus (e.g. select a SuperClass in Schema Editor) have "duplicate" (same schema.name but different schema.id) values.

Up for discussion: How best to distinguish schemas with duplicate names. Maybe show to the user schema.name along with schema.id? (e.g. Part (org.model.registry.Part) and Part (org.clothocad.model.Part) listed)

maxbates commented 9 years ago

I think we decided that schema names were deterministic and I was building around that assumption

jcaucb commented 9 years ago

Names are not unique. ID's are unique in Clotho. It has always been that way.

On Thu, Feb 19, 2015 at 1:29 PM, Maxwell Bates notifications@github.com wrote:

I think we decided that schema names were deterministic and I was building around that assumption

— Reply to this email directly or view it on GitHub https://github.com/CIDARLAB/clotho3/issues/484#issuecomment-75140048.

J. Christopher Anderson, Ph.D. Associate Professor Department of Bioengineering http://andersonlab.qb3.berkeley.edu/

Office: 512E Energy Biosciences Building (EBB) Lab: 5th Floor EBB

Mailing Address: J. Christopher Anderson University of California, Berkeley 512E Energy Biosciences Building Berkeley, CA 94720

billcao commented 9 years ago

A solution we brought up would be to make the drop downs similar to the command bar with the popovers. However to me that seems a bit too much because the list of schemas is just that, a list of schemas.

jcaucb commented 9 years ago

Minimally it needs to show what the ID is so that the user can see the difference between two things called "part". Including the description may or may not be justified.

On Thu, Feb 19, 2015 at 1:38 PM, Bill Cao notifications@github.com wrote:

A solution we brought up would be to make the drop downs similar to the command bar with the popovers. However to me that seems a bit too much because the list of schemas is just that, a list of schemas.

— Reply to this email directly or view it on GitHub https://github.com/CIDARLAB/clotho3/issues/484#issuecomment-75141558.

J. Christopher Anderson, Ph.D. Associate Professor Department of Bioengineering http://andersonlab.qb3.berkeley.edu/

Office: 512E Energy Biosciences Building (EBB) Lab: 5th Floor EBB

Mailing Address: J. Christopher Anderson University of California, Berkeley 512E Energy Biosciences Building Berkeley, CA 94720

cidar-buildbot commented 9 years ago

It doesn't make sense to have the unique field be id for everything but schemas. Schema IDs are unique. Schema names aren't specially enforced to be unique (though they could be, but I don't see much benefit)

I would just show the id - possibly truncated in the middle for very long id names?

On Thu, Feb 19, 2015 at 4:29 PM, Maxwell Bates notifications@github.com wrote:

I think we decided that schema names were deterministic and I was building around that assumption

— Reply to this email directly or view it on GitHub https://github.com/CIDARLAB/clotho3/issues/484#issuecomment-75140048.

billcao commented 9 years ago

I've gone ahead and just showed the Schemas in the form of name (id). See below for explicit example. Will close this issue when I commit/push it into master.

image

jcaucb commented 9 years ago

I like that solution

On Thu, Feb 19, 2015 at 2:05 PM, Bill Cao notifications@github.com wrote:

I've gone ahead and just showed the Schemas in the form of name (id). See below for explicit example. Will close this issue when I commit/push it into master.

[image: image] https://cloud.githubusercontent.com/assets/3446511/6277064/4a9ed30a-b840-11e4-8535-75898dfda7d2.png

— Reply to this email directly or view it on GitHub https://github.com/CIDARLAB/clotho3/issues/484#issuecomment-75148476.

J. Christopher Anderson, Ph.D. Associate Professor Department of Bioengineering http://andersonlab.qb3.berkeley.edu/

Office: 512E Energy Biosciences Building (EBB) Lab: 5th Floor EBB

Mailing Address: J. Christopher Anderson University of California, Berkeley 512E Energy Biosciences Building Berkeley, CA 94720