one-or-more(zero-or-more)) missing accept node

CIDARLAB / knox

Full stack application for creating, combining, and storing combinatorial genetic design spaces.

BSD 3-Clause "New" or "Revised" License

10 stars 9 forks source link

one-or-more(zero-or-more)) missing accept node #11

Closed dany-fu closed 5 years ago

dany-fu commented 5 years ago

I tried to replicate this on the UI by applying the operators manually and Knox became unresponsive, but I didn't get any error logs.

The missing accept node bug can be replicated with this SBOL on the combinatorial_sbol branch

oneormore_zeroormore.txt

nroehner commented 5 years ago

This should now be fixed as commit 0b675ed2a23ae8e2bc3c337507679b8c87d99a05. There was a bug in the removeBlankCycles method of the NodeSpace class where the types of nodes in blank edge cycles failed to be carried over when transforming and removing the blank edge cycles.