search

CIDARLAB / knox

Full stack application for creating, combining, and storing combinatorial genetic design spaces.
BSD 3-Clause "New" or "Revised" License
11 stars 10 forks source link

Import of Combinatorial SBOL with Hierarchical Ordering #9

Closed nroehner closed 5 years ago

nroehner commented 5 years ago

Importing the attached file (hierarchical_ordering.xml) on the combinatorial_sbol branch produces the design space pictured in hierarchical_ordering.png, when it should produce the design space pictured in hierarchical_ordering_fixed.png. hierarchical_ordering.zip

dany-fu commented 5 years ago

Fixed in latest commit by adding a check for variants in a VariableComponent

If an SBOL is missing variants in a variable component, would you rather that Knox renders an empty edge or no?

For example cds then terminator and the user forgets to include the variants for terminator, would you rather that it looks like screen shot 2019-03-07 at 11 53 33 am

or be rendered without the blank edge?

nroehner commented 5 years ago

I think it would be best if we rendered without the blank edge if possible.

dany-fu commented 5 years ago

I agree, and that's how it's shown in the latest commit, so I will leave it that way.