search

CIFASIS / QuickFuzz

An experimental grammar fuzzer in Haskell using QuickCheck
http://QuickFuzz.org
GNU General Public License v3.0
199 stars 45 forks source link

Fix Arbitrary instance for Image PixelRGBA8 #13

Closed ayberkt closed 9 years ago

ayberkt commented 9 years ago

Modify the Arbitrary instance declaration for Image PixelRGBA to resolve #12 . I realized this was a problem when my QuickCheck test kept breaking with an OutOfBounds exception; with this, I am able to successfully run the test (though I'm discarding the case when the size of the image is 0 in both dimensions). So I suppose this will fix it for you too.

gaa-cifasis commented 9 years ago

Thanks a lot for your pull request! I took your code and simplified. It is committed in c3aeef4a5f18b6473260abad9eb25cda9f3833dd. I guess we should review all the Image instances since different types of pixels have different restrictions that we can easily reproduce. If you want, you can continue to fix the other instances taking that commit as an example or simply create the bug reports and we will. In any case, you will be mentioned in the README soon as a contributor (unless you don't want).

gaa-cifasis commented 8 years ago

In any case, you will be mentioned in the README soon as a contributor (unless you don't want).

Done. Sorry it took me too long!