search

CIP-RIU / brapi

An R package to use the Breeding API (BrAPI) for accessing plant breeding data.
13 stars 7 forks source link

embed multiple studies #22

Closed bauchetg closed 6 years ago

bauchetg commented 6 years ago

Hi Reinhardt! The brapi R package is great. I was looking at the ba_studies_table() function and was wondering, if you plan to expand to collect multiple studyDbId at once? Thanks for your feedback

Guillaume

c5sire commented 6 years ago

Hi Guillaume,

thanks!

For the first iteration I had in mind to keep it close to the brapi JSON input/output. If that is compatible, it certainly would be done. I note that the brapi coordinator is going through the calls. So, I will also check if the package needs further adjustments.

In general, though, I think you point at a set of features that would be useful for the analyst to have, but may be not yet of interest to be made part of the brapi standard. I have yet not made my mind up on whether to include those or not in this package. What is your view?

My pro and con are:

con: there are quite a lot of function calls already in the package. Maybe to much to add non-standard calls?

pro: just one package to think about to do all data access/filtering from a brapi db.

Best,

Reinhard

bauchetg commented 6 years ago

Hi Reinhardt, thanks for your quick feedback. I share your pros/cons, I guess meanwhile things are being evaluated by the coordinator we can get around by doing multiple projectID queries. Thanks!

Guillaume