search

CIP-RIU / brapi

An R package to use the Breeding API (BrAPI) for accessing plant breeding data.
13 stars 7 forks source link

ba_db.R white list for snpseek #7

Closed mverouden closed 7 years ago

mverouden commented 7 years ago

The white list of known databases contains the following snpseek <- as.ba_db(secure = FALSE, protocol = "http://", db = "snp-seek.irri.org", port = 80, apipath = "ws", user = "snpseek-user", password = "snpseek-user-pass", multicrop = FALSE, crop = "rice", token = "", bms = TRUE) Is the last argument assignment TRUE? I don't think this database is running BMS, otherwise multicrop should probably also be TRUE.

As you can see I have restructured the ba_db.R file to match the function argument order as given in as.ba_db.R and put each argument on a new line for readability.

c5sire commented 7 years ago

Thanks for catching and changes. You are right - it is not a bms type db.