CIRADA-Tools / FRion

Ionospheric Faraday rotation correction for Stokes Q/U cubes
MIT License
7 stars 4 forks source link

Expose kwargs #5

Closed AlecThomson closed 1 year ago

AlecThomson commented 1 year ago

A simple change to optionally expose the kwargs of RMextract.getRM within the API. Makes no difference to default usage.

AlecThomson commented 1 year ago

The idea behind this is to really to allow us to query different IONEX servers / locations if/when the default ones go offline

tjgalvin commented 1 year ago

This seems OK to me.

Cameron-Van-Eck commented 1 year ago

Thanks for doing this. Since the default IONEX source is already dead (for observations in 2023), I was already thinking that this might have to be done (unless RMextract is modified to change the default).

AlecThomson commented 1 year ago

Thanks @Cameron-Van-Eck. I'm currently downloading the old source and, if this works like I hope, it allows offline use by using e.g.

server="file://path/to/local/ionex/copy"

The same should be true for a working online copy, too!