CIRADA-Tools / FRion

Ionospheric Faraday rotation correction for Stokes Q/U cubes
MIT License
7 stars 4 forks source link

New pre_download functionality breaks usage #6

Closed AlecThomson closed 1 year ago

AlecThomson commented 1 year ago

Hey @Cameron-Van-Eck,

Just a heads up that the added pre_download stage (with some other changes) has broken usage if pointing to other servers.

I think the fix should be pretty simple, so I'll open an PR shortly.

Also, just to check, RME.getRM already calls the section:

    ionexf=ionex.get_urllib_IONEXfile(time=start_time.value,prefix=prefix,outpath=ionexPath,overwrite = False)

assert (ionexf!=-1),"RMextract fails to recognize IONEX file."

So think this can be omitted. Is that right? Otherwise, it could be moved into _predownload_CDDIS to be self-contained. Happy to go over that detail in the PR as well.