search

CIRADA-Tools / RM-Tools

RM-synthesis, RM-clean and QU-fitting on polarised radio spectra
MIT License
42 stars 23 forks source link

Fix RMSF and add return vals #129

Closed AlecThomson closed 4 months ago

AlecThomson commented 4 months ago

Closes #128

AlecThomson commented 4 months ago

Python 3.8 tests seem to be failing on Bilby issues for some reason. But otherwise I think this is looking ok

AlecThomson commented 4 months ago

Interesting, numpy-1.22.3 and bilby-2.2.2 seem to be incompatible on the Python 3.8 tests. Bumping the numpy version up in the tests seemed to do the trick. I'll try to put this in the setup.py to avoid the issue for users

AlecThomson commented 4 months ago

@Cameron-Van-Eck when you get a chance to squiz, I think this is g2g