search

CIRCL / AIL-framework

AIL framework - Analysis Information Leak framework. Project moved to https://github.com/ail-project
https://github.com/ail-project/ail-framework
GNU Affero General Public License v3.0
1.3k stars 282 forks source link

LUHN check on credit cards #447

Closed syloktools closed 1 year ago

syloktools commented 4 years ago

Can a luhn check be added to validate credit card numbers?

https://pypi.org/project/fast-luhn/

adulau commented 4 years ago

I thought we do it there https://github.com/CIRCL/AIL-framework/blob/ecd14b91d95af3960c56719a8227ffc5ddd5e4ff/bin/CreditCards.py#L68

Do you have any specific issues?

syloktools commented 4 years ago

I have seen some invalid card such as 4777777777777777

Terrtia commented 4 years ago

Hi @robertnixon2003 !

I did some test and didn't find any issue with your Luhn implementation, 4777777777777777 is not detected as a valid credit-card

Can you share a sample of one of your false positive ?