CIRCL / AIL-framework

AIL framework - Analysis Information Leak framework. Project moved to https://github.com/ail-project
https://github.com/ail-project/ail-framework
GNU Affero General Public License v3.0
1.29k stars 283 forks source link

Added support for username as notification credentials #463

Closed KywoSkylake closed 4 years ago

KywoSkylake commented 4 years ago

Dear Ail Team,

I recently found a little problem as example our email server needs an username instead of an email address and therefor Ail cannot send any emails.

I added the support for this matter and tested it, and it worked.

Thank you Mike

codecov-io commented 4 years ago

Codecov Report

Merging #463 into master will decrease coverage by 0.03%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #463      +/-   ##
==========================================
- Coverage   12.02%   11.99%   -0.04%     
==========================================
  Files          74       74              
  Lines        7574     7646      +72     
==========================================
+ Hits          911      917       +6     
- Misses       6663     6729      +66
Impacted Files Coverage Δ
bin/NotificationHelper.py 0% <0%> (ø) :arrow_up:
bin/lib/Domain.py 21.13% <0%> (-0.72%) :arrow_down:
bin/Global.py 0% <0%> (ø) :arrow_up:
bin/IPAddress.py 0% <0%> (ø) :arrow_up:
bin/packages/Tag.py 54.23% <0%> (+0.08%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update addb885...7888f54. Read the comment docs.

Terrtia commented 4 years ago

Hi @petmi627 ! Good catch, Thank you !