search

CIRDLES / Calamari

Reimplementation of data reduction from Ludwig's Squid 2.50 for SHRIMP mass spectrometers.
Apache License 2.0
1 stars 7 forks source link

Updated expected reports #25

Closed johnzeringue closed 8 years ago

johnzeringue commented 8 years ago

Updated and reenabled the expected reports to match the output of #24.

johnzeringue commented 8 years ago

It would be good to update expected reports in every pull request that changes the data reduction or reporting, acknowledging any changes. I feel weird about doing any refactoring, performance, or other improvements with our basic checks enabled.

bowring commented 8 years ago

I appreciate the sentiment - however, the workflow has been that I need to send builds to @sbodorkos for review of the results and it seems pointless to keep updating with bad test cases. In any case, we are now confirmed to be correct, so thanks for taking the time to do this.