search

CIRDLES / Squid

Squid3 is being developed by the Cyber Infrastructure Research and Development Lab for the Earth Sciences (CIRDLES.org) at the College of Charleston, Charleston, SC and Geoscience Australia as a re-implementation in Java of Ken Ludwig's Squid 2.5. - please contribute your expertise!
http://cirdles.org/projects/squid/
Apache License 2.0
12 stars 24 forks source link

Does Squid3 have a limit on the number of mass-stations in a Task? #341

Closed sbodorkos closed 5 years ago

sbodorkos commented 5 years ago

@bowring I know Squid3 caters to 22-peak Tasks because we tried one out as part of specifying the Isotope Ratios interface. Is that the upper limit at present?

Allen Kennedy has advised that he has a 27-peak Task that he can't run (and he has other Tasks that run to 34 peaks). His 27-peak Task is here: SquidTask_AX27pk .zip . I have asked for a matching Prawn XML file; I will post that when I get it.

AllenKennedy commented 5 years ago

I have another Task that won't load. The Task audit says there are 0 peaks in the task that match the peaks in the xml data file, which loads without issue. SQUID3Task AX10.zip

NicoleRayner commented 5 years ago

I'm trying to unzip those files and getting an Unspecified error message. "Cannot complete the extraction".

I was able to extract the AX27pk.zip without any trouble. Can you try and recompress/send?

sbodorkos commented 5 years ago

Yes, I too am unable to extract the AX10 zip, but the AX27 one was fine...

bowring commented 5 years ago

Try using the files in the github issue instead of the email.

bowring commented 5 years ago

i have same problem even then

sbodorkos commented 5 years ago

I did try both, after struggling with the ZIP I initially downloaded direct from the email notification. But going into this issue and downloading the ZIP from here didn't make any difference to the the problems I am having with extracting the files in the archive.

I think I have seen this before, when I pressed the Comment button before my ZIP attachment had finished uploading... that might be the issue here too,

bowring commented 5 years ago

The issue with SquidTask_AX27pk.xls (the only file I can download) is that even though it was generated by Squid 2.5, it contains a row in the equations at line 34 starting with "Hidden Eqn". Based on my previous exposure to squid 2.2 vs 2.5, this line only appeared in Squid 2.2 created tasks. I will work to make the detection more robust. In the short term, delete this line from the Squid 2.5 task excel file.

sbodorkos commented 5 years ago

Aha. Well, sight unseen, I'd guess the AX10 Task in this issue will have the same problem, assuming it was created in the same ("non-compliant") version of SQUID 2.50. And I guess the reason there was no issue with the "XX10" Task Allen used in the XENO .squid file is because it was created in a different (newer?) version of SQUID 2.50, which creates Tasks compliant with the existing parser.

bowring commented 5 years ago

The fix for now will be to ignore the line starting with "Hidden" as I have yet to see any content in this line. Is it ever used and if so for what?

sbodorkos commented 5 years ago

I think that will be fine as a permanent solution. I believe HI(dden) in SQUID 2.50 was a expression-Switch that allowed SQUID 2.50 users to automate the Hiding of the Excel columns containing selected expression outputs (usually the results of 'intermediate' calculations), to control decluttering of the resulting SQUID-book. I don't believe it is a relevant consideration in Squid3.

bowring commented 5 years ago

Given that: 1) the task-opening issue is resolved 2) there are no built-in constraints in Squid3 re: count of mass stations 3) the lack of relevant prawn files

I am closing this issue. When we get a working example of one of the mentioned problems, let's make an issue for it.