CIRDLES / Squid

Squid3 is being developed by the Cyber Infrastructure Research and Development Lab for the Earth Sciences (CIRDLES.org) at the College of Charleston, Charleston, SC and Geoscience Australia as a re-implementation in Java of Ken Ludwig's Squid 2.5. - please contribute your expertise!
http://cirdles.org/projects/squid/
Apache License 2.0
12 stars 24 forks source link

RM naming - delimiter vs filter #480

Closed NicoleRayner closed 4 years ago

NicoleRayner commented 4 years ago

I always assumed that the RM sample name was defined by the delimiter (just like all the other samples), not the filter used to assign it. However this is not the case, which means when you go to the visualization (concordia or wt mean) the name of the RM is whatever you used to type into the filter. If the RM has a really distinctive name, one might only filter using the first few letters: RM name in name manager RM name in visualizations

This is less than ideal, but is mostly an aesthetic/clarity of labelling problem on the plots. Can obviously be overcome by typing in the full name of the RM into the filter, but if it is easy to transition the RM name from the filter to the delimiter that would be better.

bowring commented 4 years ago

So if you use the hyphen as the delimiter and the dropdown box of sample names to "type" your filter, you get TEMORA. It appears you are using a count of 3 characters as the delimiter?

NicoleRayner commented 4 years ago

I have set the hyphen as the delimiter, not character count. When I use the filter to define the RM (no dropdown box, just start typing in the the Manage Sample field) I might only type a couple of characters because that is enough to identify the RM (we commonly use one that starts with 6 , most of our unknown samples start with 1 _). So then whatever I put in the filter (1 character, 3 characters) becomes the label that appears on plots etc (lower image above).
image

SQUID "knows" that the name is 6266 because that is what I have set in the delimiter (it shows up properly in the dropdown), it just uses the filter as the ID moving forward, not the name.

bowring commented 4 years ago

My point is don't type anything, use the dropdown box to get the full set of sample names and pick one.

NicoleRayner commented 4 years ago

Yes - there are many ways to solve this problem (type it fully, or use the dropdown). Maybe we don't need the filter option, it provides 2 ways to do the same thing and one of those ways is prone to funny labelling further downstream.

bowring commented 4 years ago

I agree - I added the dropdown a while back but left the filter typing in ... it really serves no purpose since you are going to choose a sample by name ultimately. OK if we remove it?

bowring commented 4 years ago

@NicoleRayner and @sbodorkos - thoughts?

NicoleRayner commented 4 years ago

OK by my to remove the filter option.