search

CIRDLES / Squid

Squid3 is being developed by the Cyber Infrastructure Research and Development Lab for the Earth Sciences (CIRDLES.org) at the College of Charleston, Charleston, SC and Geoscience Australia as a re-implementation in Java of Ken Ludwig's Squid 2.5. - please contribute your expertise!
http://cirdles.org/projects/squid/
Apache License 2.0
12 stars 24 forks source link

Squid 1.10.2 common Pb preferences don't stick #724

Closed NicoleRayner closed 2 years ago

NicoleRayner commented 2 years ago

The modification that linked the common Pb model selection for the RM to the default common Pb correction for the unknowns (aka a custom common Pb model for the RM = the same model for unknows, or the SK model for the RM = SK for the unknowns) is no longer working. See issue #704 for further details. I think this was implemented in v1.10.1 but when the common Pb bug was fixed in v1.10.2 it was lost.

bowring commented 2 years ago

That turned out to be problematic. The current mechanism is that in the Project Manager, if the checkbox "Default for Unknowns" is checked and set as the default using the "Set Default" button to the left, then a new project will default the Unknowns commonPb to using the model chosen; if unchecked and made the default, then Unknowns default to using SK. The checkbox has no effect after the project initialization so as to not override any decisions made on the CommonPb setup for Unknowns. We can discuss?

NicoleRayner commented 2 years ago

I didn't notice the checkbox before - my mistake. What you describe above sounds good - and makes sense. I'm trying to get a bunch of stuff done before heading out for field work on Sunday so would prefer to hold on any discussion (but not even sure if it is necessary!)

bowring commented 2 years ago

@NicoleRayner - this still an issue?

NicoleRayner commented 2 years ago

No this is good now. I didn't clue in about the check box before.