search

CIRDLES / Topsoil

Community-driven replacement for Isoplot
Apache License 2.0
28 stars 35 forks source link

Fixed Institute MRU folder for saving plots #440 #461

Closed GarreBrenn closed 4 years ago

bowring commented 4 years ago

Looking good - however, if I simply open a recently used project and then try to close Topsoil I am asked if I want to save changes - this should not happen if no changes have occurred. Also, @GarreBrenn - make the change to new project that we discussed in meeting.

GarreBrenn commented 4 years ago

I noticed that issue as well. Over winter break I added an enhancement issue to the Topsoil GitHub. I just assumed that Topsoil always did that but if it’s just my branch, then we need to look into the condition of when it displays that popup and how it’s related to RecentFiles.

As far as the other proposition, I’ll get to it as soon I can.

On Wed, Jan 15, 2020 at 1:41 PM Jim Bowring notifications@github.com wrote:

Looking good - however, if I simply open a recently used project and then try to close Topsoil I am asked if I want to save changes - this should not happen if no changes have occurred. Also, @GarreBrenn https://github.com/GarreBrenn - make the change to new project that we discussed in meeting.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/CIRDLES/Topsoil/pull/461?email_source=notifications&email_token=ALHP4JOGTXPIZXSMEBWMG43Q55KFHA5CNFSM4J6ZWIR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJBK7JA#issuecomment-574795684, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALHP4JJ3TAPS5X4HE5M7GDDQ55KFHANCNFSM4J6ZWIRQ .

bowring commented 4 years ago

I am not sure how @marottajb implemented the test for ischanged, but it is probably a flog that just needs to be initialized to false when a project is loaded. Maybe he will chime in.