search

CIRDLES / Tripoli

Tripoli imports raw mass spectrometer data files and supports interactive review and archiving of isotopic data. Tripoli facilitates visualization of temporal trends and scatter during measurement, statistically rigorous filtering of data, and calculation of statistical parameters.
http://cirdles.org/Tripoli/
Apache License 2.0
8 stars 12 forks source link

Update Delx Adapt #85

Closed RoyalBoggs closed 1 year ago

RoyalBoggs commented 1 year ago

not outputting correct size matrix to delx adapt

bowring commented 1 year ago

@RoyalBoggs - did you solve the problem of single value in delxadapt?

RoyalBoggs commented 1 year ago

@bowring I believe you are referring to the delx_adapt_slice, I was able to confirm executing the matlab code in the command window that delx_adapt(:,mod(m,datsav)+1) returns a 1 x 20 column slice out of the delx_adapt matrix which is what is currently implemented, the current code however has a incorrect looking signal noise histogram which I believe stems from a bug in updateMSv2() which I'm currently investigating

RoyalBoggs commented 1 year ago

@bowring signal noise histogram returned to normal after changing adaptive flag counter to 10000 from 100 where I had it for testing, with it so low it breaks some of the logic for operation noise case in DataModellerOutputRecord updateMSv2 leading to signal noise not being adjusted, not sure that is bug or feature. Leads me to believe should stop working on delx adapt until algorithm for turning it on is set. That aside the multivariate normal distribution section of delx adapt I believe to be correct.

bowring commented 1 year ago

@RoyalBoggs - I set adaptiveflag at counter >= 1000 with max count of 2000 and got good results.

bowring commented 1 year ago

@RoyalBoggs - great work!

bowring commented 1 year ago

@RoyalBoggs - followup - chatted with @noahmclean and showed him results - there is some misbehavior but it is related to some coded in assumptions ... these will get fine-tuned with @sbordyak .