CIROH-UA / NGIAB-CloudInfra

NextGen In A Box: NextGen Generation Water Modeling Framework for Community Release (Docker version)
https://docs.ciroh.org/docs/products/Community%20Hydrologic%20Modeling%20Framework/nextgeninaboxDocker/
12 stars 19 forks source link

NGIAB throwing error while running with AWI_002 #87

Closed arpita0911patel closed 9 months ago

arpita0911patel commented 10 months ago

Current behavior

Seeing below error while trying to run the NGIAB using latest image:

At declaration of smc_profile size, soil_reservoir.n_soil_layers = 0 terminate called after throwing an instance of ‘realization::ConfigurationException’ what(): Multi BMI formulation cannot be created from config: cannot find available data provider to satisfy set of deferred provisions for nested module at index 1: {ice_fraction_xinanjiang} ./HelloNGEN.sh: line 116: 14 Aborted $run_command

Expected behavior

Run successfully

Steps to replicate behavior (include URLs)

  1. Run NGIAB using AWI_002 data.

Screenshots

arpita0911patel commented 10 months ago

Nels Frazier 3:08 PM The realization needs updated. The latest NGEN submodules include updates to the models where some names have changed Nels Frazier 3:17 PM https://github.com/NOAA-OWP/cfe/blob/master/realizations/realization_cfe_pet.json Here is the realization used for the CFE ngen integration test

benlee0423 commented 10 months ago

Do we need to create AWI_003 with new realization?

arpita0911patel commented 10 months ago

Yes, waiting on @hellkite500 to provide the updated realization file as I see many differences between the two and would like to make sure we use the correct one.

benlee0423 commented 10 months ago

Attached is new realization file, and tested with latest image, and it worked. awi_simplified_realization.json

Changes I made

"sloth_ice_fraction_xinan(1,double,1,node)": "0.0",
--> "sloth_ice_fraction_xinanjiang(1,double,1,node)": "0.0",

"ice_fraction_xinan": "sloth_ice_fraction_xinan",
--> "ice_fraction_xinanjiang" : "sloth_ice_fraction_xinanjiang", 

Run Result:

./guide.sh

...
pulling container and running the model
latest: Pulling from awiciroh/ciroh-ngen-image
eef9fc884e2c: Already exists 
49dec8df7846: Pull complete 
4d7819521e5f: Pull complete 
e999c738f9e9: Pull complete 
395d4e3bdc63: Pull complete 
4f4fb700ef54: Pull complete 
943c23c818f0: Pull complete 
ad0edb33c4d3: Pull complete 
...

Finished routing
NGen top-level timings:
    NGen::init: 7.8695
    NGen::simulation: 14.4193
    NGen::routing: 101.238
************ TIMING SUMMARY ************
----------------------------------------
Network graph construction: 0.64 secs, 0.63 %
Forcing array construction: 95.06 secs, 93.91 %
Routing computations: 1.52 secs, 1.5 %
Output writing: 4.0 secs, 3.96 %
----------------------------------------
Total execution time: 101.22 secs

real    2m4.881s
user    2m15.961s
sys 0m16.752s
Finished executing command successfully.
benlee0423 commented 10 months ago

@hellkite500 Please confirm if the change above in the realization file looks correct to you.

hellkite500 commented 9 months ago

Yes, this is the minimal change to get the latest CFE to work correctly via the model engine. Thanks for trying this out!