CISCapstone2023 / svsu-course-scheduler

A course scheduler for SVSU
2 stars 0 forks source link

Courses split by Lecture/Lab with duplicate or multiple names in cells #268

Open MatchaOtter opened 1 year ago

MatchaOtter commented 1 year ago

Describe the bug Some Excel entries for courses that are Lecture/Lab split have the faculty listed twice in the same cell. Previously, I got around this by altering the Excel files to have 1 faculty name as I thought these were duplicates or placeholders. For scheduling, this makes sense as some courses have different professors between lecture/lab, but these are not entered as separate course entries in Excel.

When attempting to import the Excel with entries like this, the double entries are considered one entry.

To Reproduce Steps to reproduce the behavior:

  1. Import BIOL or CHEM Excel sheet
  2. See error message

Expected behavior Honestly unsure. Could be to revise Excel formatting to split these into multiple entries for courses or be able to assign multiple faculty to a course.

Screenshots Importing error for double faculty name and its Excel entry. image

Adding a faculty entry for the "double name" for the above faculty allows it to pass and moves to the next "faculty" image

Desktop (please complete the following information):

brendanfuller commented 1 year ago

Yeah LAB was never supported (as CSIS never had them) although it shouldn't really matter as that column values are never checked for the value.

This was not really an oversight but more expecting these files to have LAB on a new row (which would work fine), but they decided to group every single course together (and yes I understand some of the data matches but for ease).

This would have to be a Version 2 feature, or the LAB courses would just need to be added to a new row and separated from the LEC to work as intended in this Version 1.1

I think this is also the issue for #267 because locations become broken with LAB.