search

CITCOM-project / causcumber

Cucumber driven causal inference for testing computational models.
1 stars 1 forks source link

Automated tests #13

Open bobturneruk opened 3 years ago

bobturneruk commented 3 years ago

I'm usually the one who knows most about tests in a team. Not here.

My default suggestion would be to use pytest and have a tests folder that contains tests covering the code in the (TBD) causcumber folder (see #12). That these tests should be configured to run automatically prior to code being integrated into the main branch. It seems that there are plenty of functions that would be amenable to relatively straightforward unit tests.

bobturneruk commented 3 years ago

e.g. automation with GitHub actions https://github.com/pykale/pykale/blob/main/.github/workflows/test.yml

jmafoster1 commented 3 years ago

Ironically, despite being testers, we rarely test our own research code! I agree, though, that it's probably sensible and good practice to test what we can. Certainly the causecumber core (whatever that turns out to be) should be well tested, and probably contain more input validation to make it a bit less fragile and give more meaningful errors.