search

CITGuru / PyInquirer

A Python module for common interactive command line user interfaces
MIT License
1.92k stars 236 forks source link

Fixing apparent newline bug with `list` type question. #4

Closed MarxSoul55 closed 5 years ago

MarxSoul55 commented 5 years ago

Hello,

I was looking for a CLI package for Python and found yours to be suitable for my needs. I installed it but came across an error—whenever I ran your script examples/list.py, the prompt ended up printing a bunch of newlines before printing the actual options.

In this pull request, I replaced the layout variable from the implementation of the list question with the one present in the rawlist implementation. This seems to have fixed the issue.

I am not well-versed in this project's implementation, so please test this out on your own computer to confirm the bug and fix are valid.

joveice commented 5 years ago

5

CITGuru commented 5 years ago

Thanks for your contribution. I'll look into it and run it against many use cases and environment. :+1:

CITGuru commented 5 years ago

After some testing, it doesn't quite work on some terminals and environments. Like it didn't fix mine. I still don't know why but I am looking it.

MarxSoul55 commented 5 years ago

For reference, I'm on Windows 10 with an instance of PowerShell in VSCode (no admin permissions).

CITGuru commented 5 years ago

Its been merged to both dev and master branch

jackiewatanabe commented 5 years ago

@CITGuru thanks for merging this! Would you be able to update the tags so that we can get the latest bugfix changes when we pip install?