CJ42 / LUKSO-Hardhat-template

10 stars 5 forks source link

Base Uri encoding #1

Closed Tuszy closed 9 months ago

Tuszy commented 11 months ago

Hi Jean,

Short question. Why are you setting only the url without the bytes4 prefix (https://github.com/CJ42/LUKSO-Hardhat-template/blob/recipes/test/NFTCollection.ts) for the base uri. According to the docs we need either 0x00000000 or 0x6f357c6a depending on the Token Id Type (https://github.com/lukso-network/LIPs/blob/main/LSPs/LSP-8-IdentifiableDigitalAsset.md#lsp8tokenmetadatabaseuri). Are the docs outdated regarding this?

CJ42 commented 9 months ago

@Tuszy the docs have changed and now use VerifiableURI without any bytes4 prefix.

image

Closing this issue as not applicable anymore.