search

CJCombrink / SpellChecker-Plugin

SpellChecker Plugin for Qt Creator
GNU Lesser General Public License v3.0
143 stars 26 forks source link

Consider contributing the plugin to Qt Creator #108

Open jonasdeyson opened 4 years ago

jonasdeyson commented 4 years ago

Hi,

I imagine having to manually update this plugin for each Qt Creator release must be a burden. Maybe you already looked into this, but have you considered contributing it, so it comes included with Qt Creator?

Thanks for the plugin, it's been very useful.

CJCombrink commented 4 years ago

Hi @jonasdeyson!

It is a bit of a burden at the moment, especially since I had to release plugins for different Linux versions. I did and still do consider it. While I was actively working on the plugin I decided to not do this due to the limitations that it would impose on the turnaround time.

A while back (April 2019) I also restarted to consider this idea and did ask a question on how to handle the external dependency on hunspell when doing this. Unfortunately I did not get an answer, but at that time could also not spend the time. Perhaps it is something to look at during my December holiday.

Thanks for reaching out, I am glad it is working for you. I will in most likelihood get a new release out for Qt Creator 4.11 today or tomorrow. I wanted to do this last night but had load shedding (google "what is load shedding South Africa" if you don't know). After the release is out I will reach out to the mailing list again, perhaps someone can help me in this regard.

jesperkdab commented 4 years ago

Just want to let you know I love this plugin. Excellent work!

CJCombrink commented 4 years ago

@jesperkdab @jonasdeyson I have released a new version for Qt Creator 4.11. Please test and let me know if it works for you. Once I have some feedback that I did not break something I will reach out to the mailing list to see if I can't make a plan to get the plugin integrated into QtCreator.

jonasdeyson commented 4 years ago

@CJCombrink Thanks for the update, v2.0.5 worked fine. Good luck with the integration process.

jesperkdab commented 4 years ago

Works like a charm. Esp once I downloaded the 32 bit version. Glad you had that clarification. An alternative to integrating it in QtC would be to put it on the Qt Market place: https://www.qt.io/marketplace

wstokes commented 3 years ago

@jonasdeyson any progress on getting this integrated into a future Qt Creator release directly? I'm finding this plugin terribly useful but I cannot install it under Qt Creator 4.14 at the moment until a new tag compiled against the new Qt Creator is made available.

precht commented 3 years ago

Hi all!

Firstly, thanks for the plugin - it's exactly what I was looking for!

Secondly, if adding the plugin to QtCreator is not possible, have you considered building packages for popular Linux distros?

For example, I'm using Ubuntu 20.04 and I wanted to use the plugin with QtCreator from the system repo. Since QtCreator version is 4.11, I tried the pre-compiled 2.0.5 version of the plugin but it didn't work. I managed to compile the sources of that version but it would be really awesome if the Ubuntu repo had a package like "qtcreator-spellchecker-plugin".

PS. For other people trying to compile it under Ubuntu 20.04, I had to replace QTC_LIB_NAME = KSyntaxHighlighting with QTC_LIB_NAME = KF5SyntaxHighlighting in QtCreator sources and install libkf5syntaxhighlighting-dev.

CJCombrink commented 3 years ago

@wstokes @precht Thanks for using the plugin and the feedback.

I still want to integrate with the Qt Creator sources but that is not on my todo list in the short term due to issues with my personal computer used for the development and other after work commitments. I also need feedback from the Qt team about my third party dependencies.

The issue with Ubuntu 20.04 is not something I am planning to address at this time. I would suggest installing the latest version of Qt Creator and then installing the plugin. If you have issues then please contact me and I will look into it. At the start of development I made the call to only support the latest version of Qt Creator per plugin release. I don't think there is technical reason why one can't and should not install the latest Qt Creator on Ubuntu 20.04.

bam80 commented 2 years ago

have you considered building packages for popular Linux distros

I suggested #136 to address this even better. Maybe someone could provide some help, too. Qt Creator on Flathub is always latest and it brings other benefits being mainstream distribution channel rather than custom one from Qt Maintenance Tools.

Having that, are there nearby future plans of bringing the plugin to Qt Creator upstream? PS: the second part of my note is probably answered on the linked issue above:

For now I am leaving the issue open since it is on my roadmap, I am just not sure when I will be able to pick up on this.

bam80 commented 2 years ago

@CJCombrink please ping me if you need a help to upstreaming the plugin to Qt Creator or the Qt Market place. Just installed Qt Creator 9.0 and got the plugin non-working..