search

CJNE / thermiagenesis

Home assistant custom component for Thermia Inverter/Mega heat pumps
MIT License
20 stars 12 forks source link

Make heat pump type a selection item in config flow #234

Closed mairas closed 6 months ago

mairas commented 10 months ago

This PR has two minor changes. If you'd prefer two separate PRs instead, I'm happy to do that as well!

First, the translation files present in the component cause issues at least when the English language UI is used (lots of translation errors instead of intended strings). Since the translation files don't really do anything at the moment, I removed them altogether.

Second, in the initial config flow, the heat pump type (inverter vs mega) is now a selection item (radio buttons) instead of a free-form string field.

josbmw commented 10 months ago

Thanks Mairas.

Can I easyily upgrade my current configuration based on CNJE without loosing any settings?

mairas commented 10 months ago

Thanks Mairas.

Can I easyily upgrade my current configuration based on CNJE without loosing any settings?

Yes, this has no impact on the settings schema.

josbmw commented 10 months ago

Just updated HA to 2023.11.1. Issues with this plugin:

Logger: homeassistant.setup Source: setup.py:359 First occurred: 11:58:00 (1 occurrences) Last logged: 11:58:00

Unable to prepare setup for platform thermiagenesis.climate: Platform not found (No module named 'homeassistant.util.temperature').

Any ideas?

josbmw commented 10 months ago

Restored back to 2023.10.5. Everything back as it should.

mairas commented 10 months ago

Works for me. And definitely unrelated to this PR, in any case. If you think it's an actual code problem, please open a new issue for that.

mairas commented 9 months ago

Thank you for the contribution, very nice! Instead of deleting the translation files it would be better to fix them so that translations will actually work. I can take a look at that, so take out the removal of the translation files and then we can merge the other change :)

Sure thing! Couldn't figure out that myself. :-D

I removed that commit, it's all yours!