search

CJSCommonPlatform / govuk_single_page_pdk

Single Page Platform Development Kit
http://cjscommonplatform.github.io/govuk_single_page_pdk/
13 stars 20 forks source link

Accessibility: usage of <i> should be semantic #106

Closed K-T-O closed 7 years ago

K-T-O commented 8 years ago

Pa11y warns about the following issue:

Warning: Semantic markup should be used to mark emphasised or special text so that it can be programmatically determined.

This occurs for example in gov-notification.

fabiotisci commented 7 years ago

could you paste how you have implemented the component? It's has multiple implementations and it is difficult to know what the problem could be otherwise

K-T-O commented 7 years ago

It exists for example in: http://cjscommonplatform.github.io/govuk_single_page_pdk/#/components/banners it's often used as an icon. While it has a specific semantic meaning in HTML5 and this is what pa11y warns about (it's not an error just a warning).

fabiotisci commented 7 years ago

@trevorsaint any input about this? the problem seems to be the tick icon that's using an tag

trevorsaint commented 7 years ago

@fabiotisci I would not worry so much about this particular issue. It's presentational and we have the following attributes applied:

role="presentation" aria-hidden="true"

So all is fine. If it is a really big issue we could always change it to a span. But lets leave it as it is.