header-footer minimal view

CJSCommonPlatform / govuk_single_page_pdk

Single Page Platform Development Kit

http://cjscommonplatform.github.io/govuk_single_page_pdk/

13 stars 20 forks source link

header-footer minimal view #115

Closed rak2112 closed 7 years ago

jamesbirrellgray commented 7 years ago

@rak2112 Do we have any movement on this?

jamesbirrellgray commented 7 years ago

@trevorsaint @scarlz - do you want to approve this?

jamesbirrellgray commented 7 years ago

@rak2112 I have now reviewed this. It seems yo have updated the existing components instead of creating new ones as discussed? @scarlz was this the approach discussed?

I think the "minimal" header and footer should be a separate component. Agreed @fabiotisci

b-smyth commented 7 years ago

You can view the story which its blocking progress on IDAM. https://triadmoj.atlassian.net/browse/IDAMJL-1772

This lists all the other stories this PDK update is blocking and also relates to https://triadmoj.atlassian.net/browse/IDAMJL-1773 (Remove all GOV.UK Licensed UI Components)