search

CJSCommonPlatform / govuk_single_page_pdk

Single Page Platform Development Kit
http://cjscommonplatform.github.io/govuk_single_page_pdk/
13 stars 20 forks source link

GDS Styles and PDK #48

Open trevorsaint opened 7 years ago

trevorsaint commented 7 years ago

Looking at the way the structure has been put together I am a little concerned with how we are doing things.

Why don't we have a GOVUK folder and inside this folder have:

I have a grunt/gulp task that basically copies files into these folders. NPM install pulls the latest stuff from GOV elements. Why? Because they like us are constantly pushing changes and fixes.

The benefits of this are that consistency remains and we are in-line. It's also great separation of our styles and GDS styles.

I'm very happy to discuss this and demonstrate why this is a better approach than what we have.

jamesbirrellgray commented 7 years ago

@trevorsaint I would like to conduct a review of this with @scarlz please.