search

CJSCommonPlatform / govuk_single_page_pdk

Single Page Platform Development Kit
http://cjscommonplatform.github.io/govuk_single_page_pdk/
13 stars 20 forks source link

Accessibility: Horizontal link list #59

Closed K-T-O closed 7 years ago

K-T-O commented 8 years ago

Links with similar meaning should be grouped as a list (pa11y warning) to be easily skippable. Currently in IDAM we use: Link1 | Link2 screen shot 2016-08-09 at 14 13 53

while it should be an ol/li with display: inline-block list with proper styling and padding as "|" is a character with no value to the content/meaning it's just a visualisation feature.

fabiotisci commented 7 years ago

Which PDK component is using this type of links? Please specify

K-T-O commented 7 years ago

To my knowledge no PDK component offers this kind of functionality. This issue is an enhancement request originated from requirements on IDAM.

fabiotisci commented 7 years ago

for anything to go on the PDK UX design board needs to approved, then go into the CJS CPP Design document and after that can be included on PDK. So I guess your designer will need to raise that on the design board meeting.

On Wed, 26 Oct 2016 at 14:58 K-T-O notifications@github.com wrote:

To my knowledge no PDK component offers this kind of functionality. This issue is an enhancement request originated from requirements on IDAM.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/CJSCommonPlatform/govuk_single_page_pdk/issues/59#issuecomment-256355701, or mute the thread https://github.com/notifications/unsubscribe-auth/ADE82sRnXTt8A1EXwwqbjTA7uiqM2q_aks5q31yJgaJpZM4JgD7w .

blackmonday commented 7 years ago

This isn’t a pattern that should be used going forward.

When the search users list filters story was originally worked on the “Filters” pattern hadn’t been finalised so the text links separated by a ‘|’ was used as a temporary solution until the pattern was added to the PDK. Please use the “Fitlers” pattern:

You can see the “Filtes” pattern as it should appear on page 11 of this PDF: https://triadmoj.atlassian.net/wiki/download/attachments/55705917/IdAM_v2_Support_Admin_v1.3.4_search.pdf

You can find the “Filters” pattern in the PDK here: https://cjscommonplatform.github.io/govuk_single_page_pdk/#/components/data-visualisation#gov-filters-demo