CJSCommonPlatform / govuk_single_page_pdk

Single Page Platform Development Kit
http://cjscommonplatform.github.io/govuk_single_page_pdk/
13 stars 20 forks source link

column-navigation added as per Trevor's markup #88

Closed lemmingworks closed 7 years ago

lemmingworks commented 7 years ago

I've done this declaratively as a number of components so that the order of the sections, and metadata etc can be moved around.

However, as we can't replace the angular component elements, this is adding extra markup that may not be deemed to be semantically correct.

Is it possible to add roles to this markup to make it easier for screen-readers to navigate.

If not, then we can do this in a purely data-driven way but:

We won't have the same flexibility to order the sections in as many ways, although we can produce all of the examples so far.

Looking at the markup in Trevor's examples, there seems to be html elements such as and in the metadata parts. Is it definitely a requirement to be able to render html rather than strings for the metadata, because if so we may need to use transclusion for the metadata with the associated extra angular component elements.