P Tag is larger than every other element!

[jamesbirrellgray]

It seems the p tag is 1.19em which is larger that a-tags etc.....?

[vygis]

@jamesbirrellgray this seems to be a design decision...

It wouldn't be hard to change but then we should amend the x, xs etc classes accordingly and make sure we don't break stuff in the existing apps.

[jamesbirrellgray]

@vygis why is an a tag smaller by default - it makes no sense!

[jamesbirrellgray]

@vygis can we make the change either to the default text (make 19px) so it applies to all elements - span, a etc? or update the p to start at the smae as all other elements as susggested

[vygis]

19px seems excessive, so I suppose it's best to remove the size rule for the default <p> and let it inherit from the body, and then update the smaller p classes accordingly. Let's get the new guys on this :)

[jamesbirrellgray]

@pabloibanezcom this is actually a strange one! the edge case is <li><a>foo</a><p>bar</p><li> - the console says that they are the same size, however the p tag is bigger - maybe play with in the ngGov docs to see if you can replicate

[pabloibanezcom]

@jamesbirrellgray OK, I'm going to see what's the issue

[jamesbirrellgray]

<ul class="row list-unstyled"><li><a>foo</a><p>bar</p><li></ul>

[pabloibanezcom]

I think the problem is that em transformation is applied twice for p. It gets transformated first as it's inside a ul element (this also applied to a) and then as it's a p element (here is where is the difference with a or other elements).

One suggestion could be excluding p from general ul rule but I'm going to think about it.

If anyone wants to know a bit more about this feel free to take a look at this http://www.sitepoint.com/css-font-sizing-tutorial/

[pabloibanezcom]

I'm still not 100% sure about the desired result. Must both a and p to be the same size in all conditions? Are you sure you want to dicrease the font size of the p elements?

[vygis]

Maybe this would be a good opportunity to review sitewide typography with UX?

[pabloibanezcom]

Yes. If we dicrease the current p size by removing the rule the difference between lead parapraph and the standard one will be quite big in my opinion.

[jamesbirrellgray]

Lets review this tomorrow

[pabloibanezcom]

Hi James,

Any update about this? As soon as I know what's the desired sized for p I will create the commit.

[pabloibanezcom]

Finally I removed the font transformation for regular paragraph.

https://github.com/CJSCommonPlatform/ngGovUk/commit/235d68e00936dfb05a1e606d7762cdad3cc98232