CJSCommonPlatform / ngGovUk

****** DEPRECATED ********
Other
1 stars 8 forks source link

List of links with appropriate padding #66

Open StefanTotev opened 8 years ago

StefanTotev commented 8 years ago

Can a new class be provided with the appropriate spacing between links such as:

screen shot 2016-04-11 at 15 30 49

I am currently using the < p > tag, but that provides too much spacing between the links and it looks like this:

screen shot 2016-04-11 at 15 30 57

Thanks in advance!

pabloibanezcom commented 8 years ago

Hi Stefan,

Could you please provide the html you use for it?

StefanTotev commented 8 years ago

I'm currently using :

<h4>Next steps</h4>
<p>
    <a>
        View this user's details
    </a>
</p>
<p>
    <a>
        Search for another user
    </a>
</p>
<p>
    <a>
        Search for another organisation
    </a>
</p>

This allows me to divide them into different lines and to add spacing between them

pabloibanezcom commented 8 years ago

Hi Stefan,

As each link is inside a paragraph that margin is the one defined for p:

margin-bottom: 15.232px;

However you should use multiple paragraph for this purpose. You should use a list like :

     <ul class="list-unstyled">
        <li><a>View this user's details</a></li>
        <li><a>Search for another user</a></li>
        <li><a>Search for another organisation</a></li>
      </ul>

This should work to you. If you fin the space between the links is too short now let me know and I will create a custom class to increase the margin.

StefanTotev commented 8 years ago

I have tried that as well, but the spacing is too short. Would it be possible to create a new class for this please?

jamesbirrellgray commented 8 years ago

@StefanTotev - are you on IDAM? We may need to look at the spacing for p tags - I don't want different spacing - it should be uniformly global

StefanTotev commented 8 years ago

@jamesbirrellgray Yes, I am. I absolutely agree about it being uniformly global. That's why I mentioned a new class that could handle the links and add the appropriate spacing between them without using the p tag.

pabloibanezcom commented 8 years ago

I think we should create a class (or maybe a collection of them) to apply different margin between list elements. We shouldn't use p tag for a enumeration.

If you are agree I will go for it.

StefanTotev commented 8 years ago

@pabloibanezcom I definitely agree about creating a new class (or collection of classes).

pabloibanezcom commented 8 years ago

A collection of classes have been created to implement this. Please take a look at:

http://cjscommonplatform.github.io/ngGovUk/#!/css

In your case you should use "list-unstyled" and one of these classes (maybe "list-spaced").