nus-se-bot
commented
5 days ago Team's Response
This is intended behaviour to prevent the addition of duplicate contacts. In the case of clients having the same name, we would recommend using their full name instead. In the unlikely event that 2 clients have the same full name, we think that users can additional identifiers within the name field (e.g. Bob Choo (church), Bob Choo (school)).
Items for the Tester to Verify
:question: Issue response
Team chose [response.Rejected]
- [x] I disagree
Reason for disagreement: Hi, I believe that this intended behaviour to prevent duplicate contacts could cause problems for the user if all contacts must have unique names, even if every other detail is different as contacts that are not duplicates are prevented from being added as well. It is not uncommon for two individuals to have the same full name eg (John Lim) and the suggestion to include additional identifiers such as the use of brackets within the name field is not feasible because the app currently only allows alphanumeric characters for the name field.
Allowing users to add two contacts with same names, provided there are other details that are different would give users more flexibility as well, as in the event there are two contacts with same names, users can simply use the tag field to differentiate them. Without this flexibility, users may have to add random alphanumeric characters in the name field for the second contact with same name as a previously added contact in order to add the contact, which can affect user experience. Hence, I believe that this is considered a feature flaw since contacts that should not be considered duplicates are treated as duplicates and cannot be added thus making the feature less complete for users.
(Picture taken from app)
(from course website)
steps to reproduce 1) add -c n/Harry lim p/9167 e/jd@gmail.com a/Blk 123 St 4 t/budget 2) add -c n/Harry lim p/91687 e/hl@gmail.com a/Blk 12 St 5
expected output: harry lim with phone number 91687 should be added actual output: Error message for duplicate client
Rationale: client with same name but different number, email and address are different people and thus should be accepted as well, especially if name is commonly used.