test_obfuscator_calls_helper_functions should exclusively test call to util functions in obfuscator. However, it also makes an assertion about the result. In the event of errors with obfuscator, this would cause test_obfuscator_calls_helper_functions to fail, obscuring the fault.
Proposed resolution
Separate concern of result assertion into a new unit test.
Issue
test_obfuscator_calls_helper_functions
should exclusively test call to util functions inobfuscator
. However, it also makes an assertion about the result. In the event of errors withobfuscator
, this would causetest_obfuscator_calls_helper_functions
to fail, obscuring the fault.Proposed resolution
Separate concern of result assertion into a new unit test.