search

CJohnston079 / obfuscator

0 stars 0 forks source link

Unit test `test_obfuscator_calls_helper_functions` tests expected output in addition to util function calls #9

Closed CJohnston079 closed 4 months ago

CJohnston079 commented 4 months ago

Issue

test_obfuscator_calls_helper_functions should exclusively test call to util functions in obfuscator. However, it also makes an assertion about the result. In the event of errors with obfuscator, this would cause test_obfuscator_calls_helper_functions to fail, obscuring the fault.

Proposed resolution

Separate concern of result assertion into a new unit test.

CJohnston079 commented 4 months ago

Resolved in c6855ca0e25fd50cc94fa939439eeb96a26d2c61 with proposed resolution.