CK3RealmsinExile / RealmsInExile

https://discord.gg/FKr4Zbr
31 stars 31 forks source link

Elves grant out human counties to elves and vice versa #664

Closed JukeJukestar closed 1 year ago

JukeJukestar commented 1 year ago

Elves grant out human/ feudal holdings to elves, who become feudal. Humans do the opposite with elven holdings.

jj248 commented 1 year ago

Just brainstorming some thoughts here while waiting for the wee Pichu to get back to sleep...

jj248 commented 1 year ago

I've pushed something that hopefully will fix this. Please test.

Commander-Sol commented 1 year ago

I've pushed something that hopefully will fix this. Please test.

In my testing with the elves today I noticed Galadriel granting human fiefs in Celebrant to elven characters, but it's certainly less prolific than before. Haven't seen any humans getting elven holdings though. Will attempt to replicate tomorrow.

Commander-Sol commented 1 year ago

I've pushed something that hopefully will fix this. Please test.

In my testing with the elves today I noticed Galadriel granting human fiefs in Celebrant to elven characters, but it's certainly less prolific than before. Haven't seen any humans getting elven holdings though. Will attempt to replicate tomorrow.

Confirming this happens, Galadriel consistently grants human holdings in Celebrant to elves whenever she takes counties or the duchy as a whole.

jj248 commented 1 year ago

I've tried pushing another fix for this - hopefully it won't result in Year 1 CTDs.

savagesach commented 1 year ago

image I was able to figure out how galadriel has been giving out the titles.

savagesach commented 1 year ago

is there no way to disable "grant to local noble" for different races?

savagesach commented 1 year ago

nvm I didn't read properly, that just gives the title to local culture. every time I switch from galadriel to observer mode, the ai immediately gives the title to other elves. the only thing I can think of is that there's some ai only interaction

jj248 commented 1 year ago

I believe I fixed this last night: https://github.com/MattTheLegoman/RealmsInExile/commit/3bcfd08df4d61953374b5e8bd5e7a7a6ad4fb1a6

When was your last pull?

savagesach commented 1 year ago

idk when my last pull was, but I tested it with a newly reinstalled dev version and it's still a problem image

VectorMaximus commented 1 year ago

Yep, I similarly just tested this, under the exact same circumstances. Galadriel immediately gave out the counties in Parth Celebrant to Elves.

jj248 commented 1 year ago

I've pushed an attempted fix that MAY cause CTD instability, so if that starts happening again, it's almost certainly THIS.

Jauffr commented 1 year ago

After playing a few elf games and many observer games the past few days. I can confidently say that elves can no longer hand out human counties to other elves. Humans can not hand out elven counties to other humans, though once I had a human vassal conquer an elf county and lost his old one. This meant he was stuck with a county he couldn't use. That is working as intended though and was purely his own fault

jj248 commented 1 year ago

Agreed. Serves him right. Closing.