CK3RealmsinExile / RealmsInExile

https://discord.gg/FKr4Zbr
32 stars 32 forks source link

Adaptation of Pilgrimages #913

Open BriceLeduc opened 1 year ago

BriceLeduc commented 1 year ago
JukeJukestar commented 1 year ago

Shoving this over to testing!

I reworked our entire pilgrimage ending code - theres now only one event per location, completely independent of alignment, so the background will always be used. However, the description changes depending on you alignment! Most special places should now use our awesome backgrounds for the pilgrimage activity. Regarding descriptions: We only have very few right now, until someone cooks up some more. My Radagast event is now a travel event that may trigger when travelling through Rhosgobel. I made any unfitting pulse events I could find not trigger. I also restricted pilgrimages to certain faiths - Some minor faiths such as the Nurn slaves, the Druedain and the Ainur faith will no longer have access to them

Please test this somewhat thoroughly if you find the time, just give yourself some console cash and hop around the map doing a few pilgrimages to see if you find any inappropriate events! (That should also help test travelling).

JukeJukestar commented 1 year ago

Heres a quick overview which counties should have arrival events attached to them for testing:

image

jj248 commented 8 months ago

They need a test. @savagesach and @Hendrix1337x :)

Hendrix1337x commented 8 months ago

The travel events aren't firing in gondor, mordor and Rohan(all i've tested up till now) i believe it might be because when one hovers over the destination, it isn't saying that visiting it will trigger a sightseeing event. The site at Korlea does say it and i end up getting an event when i pass through it. 1 2 3 4 5 6

JukeJukestar commented 2 months ago

Note: Theres a misconception here, these arent "city travel events" which you get by visiting a province while travelling, these are pilgrimage arrival events that fire if you go on a pilgrimage and arrive in those specific locations.

The code is pretty old and crappy, since theyre all triggered as separate events instead of being a scripted description and background inside a single event (which would be much more fancy), but i cant be bothered to change it