search

CKGrafico / inversify-props

Wrapper of Inversify to inject your dependencies in the components, made with TypeScript and compatible with Vue, React and other component libraries.
MIT License
85 stars 9 forks source link

2.0.1 is not working #21

Closed lepicekmichal closed 4 years ago

lepicekmichal commented 4 years ago

Cannot apply @injectable decorator multiple times.

Even https://github.com/CKGrafico/Frontend-Boilerplates/tree/vue is not working with 2.0.1

webnoob commented 4 years ago

I also get this on 2.0.1

Any news on a fix?

CKGrafico commented 4 years ago

Did you removed @injectablefrom your code? check the demos maybe is that

webnoob commented 4 years ago

I've made no code changes at all. @injectable exists where it always has...

Are there any breaking changes in 2.0 I need to read up on? I can't see a releases section so can't see a changelog.

webnoob commented 4 years ago

Oh wait, we don't need @injectable now?

https://github.com/CKGrafico/inversify-props/blob/master/examples/vue/src/app/shared/service1/service1.service.ts

CKGrafico commented 4 years ago

@webnoob yes injectable is not necessary anymore, sorry for the porr explanation :( I'll check how to give this info to devs. Suggestions and PRs are accepted to explain this to others

webnoob commented 4 years ago

@CKGrafico Perhaps just tag a release in the releases section and add a "Breaking Change" note in there to explain this. It was the first place I looked when upgrading as this seems to be the standard way to explain any changes to users.

CKGrafico commented 4 years ago

Yes, you're totally right I'm not maintaining this project as a project that people uses because I don't have a lot of feedback in github (at least no like in my other projects) I can see that there is some people using it, I'll try to improve the docs and releases in the future.

webnoob commented 4 years ago

Just an extra thought on this, is it worth removing injectable as a named export on the inversify-props package as well?

CKGrafico commented 4 years ago

You need for 3rd party https://github.com/CKGrafico/Frontend-Boilerplates/blob/phaser/src/app/core/phaser/phaser.injectables.ts