Unexpected warning if no endpoint specified,

CLARIAH / grlc

grlc builds Web APIs using shared SPARQL queries

http://grlc.io

MIT License

135 stars 32 forks source link

Open ecow opened 3 years ago

ecow commented 3 years ago

I think that to use the default endpoint should be perfectly legal, so probably the warning:

WARNING:No endpoint specified, using default

could be removed

c-martinez commented 3 years ago

True. Perhaps it is useful in debugging mode...

ecow commented 3 years ago

yes, it could be useful in debugging . I close the issue

ecow commented 3 years ago

I reopen this issue because looking to the code, it seams to me that in line 63 of src/gquery.py the line:

glogger.warning("No endpoint specified, using default ({})".format(endpoint))

could be rewitten as

glogger.info("No endpoint specified, using default ({})".format(endpoint))

In my opinion, Info is most appropriate level for this kind of log, also looking to similar cases in the same function.

Anyway it is just a very minor issue.

c-martinez commented 3 years ago

Thanks -- added that one to pending PR #355 on commit 6c2cf0a so it should all be merged together :-)