search

CLEANit / heatenginegym

A collection of heat engines, based on the OpenAI Gym environment framework for use with reinforcement learning applications.
14 stars 5 forks source link

RL algorithms #7

Closed millskyle closed 5 years ago

millskyle commented 6 years ago

My personal opinion is that this repo should not contain any RL algorithms. It should only contain the gym environment. Opinions?

itamblyn commented 6 years ago

Yeah, and it should not be called Carnot.

We are making a public heat_engine repo. We can probably retire this repo

On Mon, Sep 17, 2018, 8:35 PM Kyle Mills notifications@github.com wrote:

My personal opinion is that this repo should not contain any RL algorithms. It should only contain the gym environment. Opinions?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/CLEANit/carnot/issues/7, or mute the thread https://github.com/notifications/unsubscribe-auth/ABmk8mpeeWobCMlS81G-vSfnPKUchHiaks5ucD_RgaJpZM4Ws9rm .

millskyle commented 6 years ago

You should just rename this or properly move stuff over to preserve the commit history.

itamblyn commented 6 years ago

We will have a public repo called heat_engine and something internal with history. Suggestions welcome

On Mon, Sep 17, 2018, 8:51 PM Kyle Mills notifications@github.com wrote:

You should just rename this or properly move stuff over to preserve the commit history.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/CLEANit/carnot/issues/7#issuecomment-422217291, or mute the thread https://github.com/notifications/unsubscribe-auth/ABmk8q8IXgZvftHNEgs6e1hLrX17Dz1Gks5ucEOOgaJpZM4Ws9rm .

millskyle commented 6 years ago

If I have contributed to what is being released, I would like the history publically available as well. One of my main reasons of using GitHub is to prove that I use GitHub.

I'm fine if it's downstream of a private repo: e.g. a private remote and a public remote, where we only ever push working code to the public remote, but the whole point of git is to keep a record of everything.

itamblyn commented 6 years ago

Ah, that is a good point.

I have no idea how to accomplish such things!

My only request is that the name change from Carnot (because it is too specific) and that we don't hand out in progress ideas too early.

Other than that, make it sweet

On Mon, Sep 17, 2018, 10:26 PM Kyle Mills notifications@github.com wrote:

If I have contributed to what is being released, I would like the history publically available as well. One of my main reasons of using GitHub is to prove that I use GitHub.

I'm fine if it's downstream of a private repo: e.g. a private remote and a public remote, where we only ever push working code to the public remote, but the whole point of git is to keep a record of everything.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/CLEANit/carnot/issues/7#issuecomment-422232489, or mute the thread https://github.com/notifications/unsubscribe-auth/ABmk8nE3Fxoo-HzfQ_3yI2FBl-x822Tfks5ucFnRgaJpZM4Ws9rm .

millskyle commented 6 years ago

Good :). Just basically make a new repo named whatever you want and do 'git remote add public ' Set origin to the private repo and only ever push to public when you want stuff to be public.

millskyle commented 6 years ago

I'll do it and let you know.

millskyle commented 6 years ago

Okay, good to go. Here is the public version: https://github.com/CLEANit/heat_engine_gyms (It is not currently public, but can be made so later).

Step 1: Get carnot/master into a form ready for release.
Step 2: Commit to carnot/master Step 3: git remote add public https://github.com/CLEANit/heat_engine_gyms Step 4: git push public master Step 5: git remote remove public if you want to make sure you don't accidentally release some code later.

The day-to-day work can be done in carnot (in any branch), eventually merged to carnot/master, then someone can be charged with releasing publically by the above steps.

(Note that heat_engine_gyms is currently read-only for everyone but me. I can, of course add people once they feel comfortable with the additional remote, etc.)

itamblyn commented 6 years ago

Should we have one repo with many gyms? Or gym_heat_engine, gym_next_project as separate repo?

On Mon, Sep 17, 2018 at 11:02 PM Kyle Mills notifications@github.com wrote:

Okay, good to go. Here is the public version: https://github.com/CLEANit/heat_engine_gyms (It is not currently public, but can be made so later).

Step 1: Get carnot/master into a form ready for release. Step 2: Commit to carnot/master Step 3: git remote add public https://github.com/CLEANit/heat_engine_gyms Step 4: git push public master Step 5: git remote remove public if you want to make sure you don't accidentally release some code later.

(Note that heat_engine_gyms is currently read-only for everyone but me. I can, of course add people once they feel comfortable with the additional remote, etc.)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/CLEANit/carnot/issues/7#issuecomment-422238252, or mute the thread https://github.com/notifications/unsubscribe-auth/ABmk8k3U0cFFJwuuaCdL7qv12wk8BbvMks5ucGJCgaJpZM4Ws9rm .

millskyle commented 6 years ago

I would say separate. There's no point making people download and compile e.g. KMCLib if they only want the Otto cycle

itamblyn commented 6 years ago

Fair.

Make it gym_whatever then for org purposes

On Tue, Sep 18, 2018, 12:06 AM Kyle Mills notifications@github.com wrote:

I would say separate. There's no point making people download and compile e.g. KMCLib if they only want the Otto cycle

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/CLEANit/carnot/issues/7#issuecomment-422248501, or mute the thread https://github.com/notifications/unsubscribe-auth/ABmk8nUTklCyJPbf0h3_Tv3JxSG0sGVrks5ucHE1gaJpZM4Ws9rm .