Feature/add missing jrc flood impact functions

CLIMADA-project / climada_petals

See https://github.com/CLIMADA-project/climada_python first

GNU General Public License v3.0

22 stars 13 forks source link

Feature/add missing jrc flood impact functions #111

Open aleeciu opened 5 months ago

aleeciu commented 5 months ago

This PR adds the missing flood impact fucntions from the JRC publications. The current implementation only uses the "residential buildings" functions, and this PR adds those from the five more categories (or sectors as tjey are called here) available in the JRC report, i.e., commercial buildings, industrial buildings, transport, infrastructure and agriculture. To do that, I had to slightly adjust the code as one can no longer only choose the region, but both the region and a sector.

chahank commented 2 months ago

@aleeciu : could you please provide a timeline to finish this PR?

aleeciu commented 2 months ago

Apologies, I replied quite timely in fact, but I did not realize I had to click on "send the review" in order for my comment to be visible. Anyway, here you really find me in line with comments on tests in https://github.com/CLIMADA-project/climada_python/pull/734 : I am surprised about the request because the logic I followed is just the one already in the module so I find writing better tests very very important but simply beyond scope, and increasing scope is how one never gets things done :-)