CLIMADA-project / climada_petals

See https://github.com/CLIMADA-project/climada_python first
GNU General Public License v3.0
22 stars 13 forks source link

supplychain module: Wrong currency of WIOD 16 table #113

Open mastaia opened 7 months ago

mastaia commented 7 months ago

In the module: https://github.com/CLIMADA-project/climada_petals/blob/develop/climada_petals/engine/supplychain.py

On line 304, the mriot unit is assigned in M.EUR.

According to the official data download https://www.rug.nl/ggdc/valuechain/wiod/ and opening the excel table, the unit must be in M.USD

image
peanutfun commented 7 months ago

Thanks for the report. @aleeciu can you confirm this and maybe come up with a fix?

aleeciu commented 7 months ago

Yes, that's an error - thanks for spotting. It should not really affect any other piece of the code though, it's really a results' interpretation issue.

It will be fixed in https://github.com/CLIMADA-project/climada_petals/pull/81.

mastaia commented 7 months ago

Agree, it will not affect the results, but just the interpretation. Thanks a lot.