Feature/centroids as gdf

[emanuel-schmid]

Changes proposed in this PR:

• Adaptations to the centroids as gdf refactoring (climada 5.0.0-dev)

This PR fixes #

PR Author Checklist

• [ ] Read the Contribution Guide
• [x] Correct target branch selected (if unsure, select develop)
• [ ] Descriptive pull request title added
• [ ] Source branch up-to-date with target branch
• [ ] Documentation updated
• [ ] Tests updated
• [ ] Tests passing
• [ ] No new linter issues
• [ ] Changelog updated

PR Reviewer Checklist

• [ ] Read the Contribution Guide
• [ ] CLIMADA Reviewer Checklist passed
• [ ] Tests passing
• [ ] No new linter issues

[peanutfun]

@emanuel-schmid The code coverage test fails because the coverage of modified lines is too low (49%, target: 60%). Is there something we want to do about this? Do we want to add some more testing to meet the target? If we simply ignore it, the pipeline for develop might succeed after merging, because the overall quality gate might still met and there will be no check of modified files only.

[emanuel-schmid]

Yes, ignore. In this particular PR I don't see a point in adding tests - it's about making necessary adaptations to be compatible with core develop and not about improving anything at all.

I'm actually inclined to reconfigure the coverage restrictions. We could try the MODIFIED_LINES_DELTA baseline. I wonder though what we should set as THRESHOLD then - 100%?. And I wonder how it affects novel modules. Also - what about plotting and I/O methods which are supposed to be in the integration test? Perhaps we shouldn't make coverage cause failures at all.

[peanutfun]

Alright, I should have the review ready by Wednesday

[emanuel-schmid]

Unless I'm missing something we're ready for merging - right?