search

CLIMADA-project / climada_petals

See https://github.com/CLIMADA-project/climada_python first
GNU General Public License v3.0
22 stars 13 forks source link

Faulty frequency definition in LS hazard #34

Open Evelyn-M opened 2 years ago

Evelyn-M commented 2 years ago

Frequency is defined to have the same shape as intensity in the LS class, instead of being an array of event_id shape. Event_id is also meaningless in the current implementation, as the entire hazard, over whatever yearspan, is just defined as one event. Needs a re-definition and re-considering of what is an event.

https://github.com/CLIMADA-project/climada_petals/blob/78174b431294dc374cee003e839f1187a9e1443b/climada_petals/hazard/landslide.py#L160

This causes issues during impact calculations with concatenated hazards, for instance.

chahank commented 1 year ago

Is there a plan to resolve this issue in the near future?