TCForecast release bufr message - Githubissues

CLIMADA-project / climada_petals

See https://github.com/CLIMADA-project/climada_python first

GNU General Public License v3.0

22 stars 13 forks source link

TCForecast release bufr message #87

Closed ThomasRoosli closed 1 year ago

ThomasRoosli commented 1 year ago

Changes proposed in this PR:

fix a memory leak in TCForecast
Add an additional line as suggested by ecmwf themselves: https://confluence.ecmwf.int/display/ECC/bufr_read_tropical_cyclone (click on the python rider, to switch from fortran to python)
The need to release the memory is also described here: https://confluence.ecmwf.int/download/attachments/73011814/ecCodes_BUFR_API_decoding1.pdf?version=1&modificationDate=1519143448592&api=v2 (search within the pdf-file for the word "free")

This PR fixes #

PR Author Checklist

[x] Read the Contribution Guide
[x] Correct target branch selected (if unsure, select develop)
[x] Descriptive pull request title added
[x] Source branch up-to-date with target branch
[x] Documentation updated
[x] Tests updated
[x] Tests passing
[x] No new linter issues
[ ] Changelog updated

PR Reviewer Checklist

[ ] Read the Contribution Guide
[ ] CLIMADA Reviewer Checklist passed
[ ] Tests passing
[ ] No new linter issues

peanutfun commented 1 year ago

Looking good, thanks for providing the bugfix! The issue with readthedocs seems to be unrelated, so I'll merge.