Avoid redundant calls to `np.unique` in `Impact.impact_at_reg` - Githubissues

CLIMADA-project / climada_python

Python (3.8+) version of CLIMADA

GNU General Public License v3.0

321 stars 125 forks source link

Avoid redundant calls to `np.unique` in `Impact.impact_at_reg` #848

Closed peanutfun closed 9 months ago

peanutfun commented 9 months ago

Changes proposed in this PR:

Only call np.unique once in Impact.impact_at_reg.

This seems to have been an oversight during the review of #642.

PR Author Checklist

[x] Read the Contribution Guide
[x] Correct target branch selected (if unsure, select develop)
[x] Descriptive pull request title added
[x] Source branch up-to-date with target branch
[ ] Documentation updated
[ ] Tests updated
[x] Tests passing
[x] No new linter issues
[x] Changelog updated

PR Reviewer Checklist

[x] Read the Contribution Guide
[x] CLIMADA Reviewer Checklist passed
[x] Tests passing
[x] No new linter issues

sarah-hlsn commented 9 months ago

Looks good to me!